fix(client): some minor code fixes...#1176
Closed
XenoAmess wants to merge 1 commit into
Closed
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
6 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Contributor
There was a problem hiding this comment.
LGTM
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
XenoAmess
force-pushed
the
feature-fix-typehints
branch
from
d827960 to
c3d05ce
Compare
Collaborator
|
Thanks again for raising this! Closing this as stale / not longer relevant in Python SDK v3. If you continue to see issues, please open a Github issue 👍🏾 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Fix default mutable arguments, improve exception handling, and add missing class method decorator in various files.
create_prompt(),update_prompt(),observe_llama_index(), andget_llama_index_handler()inclient.pyby setting default toNoneand initializing inside the function.jsonable_encoder()injsonable_encoder.pyby directly initializing theerrorslist with the caught exception.@classmethoddecorator toflush()inopenai.py.generate_error_message_fern()andhandle_fern_exception()to useExceptioninstead ofErrorinparse_error.py.excludetoNoneinauto_decorate_methods_with()inerror_logging.py.This description was created by
for ec01658. You can customize this summary. It will automatically update as commits are pushed.
Greptile Summary
Disclaimer: Experimental PR review
This PR improves code quality and type safety in the Langfuse Python SDK by addressing mutable default arguments and enhancing error handling.
client.pyby changing empty lists/dicts toNonein methods likecreate_prompt()andupdate_prompt()@classmethoddecorator toflush()inlangfuse/openai.pyfor proper class method behaviorjsonable_encoder.pyby directly initializing errors list with caught exceptionsErrortoExceptioninparse_error.pyfor more flexible error handlingexcludetoNoneinerror_logging.pyto avoid mutable default argument issuesThe changes follow Python best practices by preventing shared state issues with mutable defaults while maintaining existing functionality.
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!